Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 a7fcd61: replace dangerous tvb_get_ptr with safer string function.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7fcd61ee97b88515347ee179cf26222926a0aad
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a7fcd61 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    replace dangerous tvb_get_ptr with safer string function.
    
    Using tvb_get_ptr to get a string is always dangerous in the face of
    malformed packets. Instead using string functions allow for safe handling
    of these.
    
    Bug: 12242
    Change-Id: I059c186032492aae9c90a69858ea3fc59e21313f
    Reviewed-on: https://code.wireshark.org/review/14714
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit ad097385c05c370440fb810e67f811398efc0ea0)
    Reviewed-on: https://code.wireshark.org/review/14731
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dc4fd75   Remove trailing whitespace.
    adds  a7fcd61   replace dangerous tvb_get_ptr with safer string function.


Summary of changes:
 epan/dissectors/packet-pktc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)