Wireshark-commits: [Wireshark-commits] master 8ba351b: Clean up some stuff.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 Mar 2016 00:45:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ba351b04b109c09956c7a69b5d91d3c87ffb180
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8ba351b by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up some stuff.
    
    Have bin2hex() wmem_allocate the buffer, so it can be used the same way
    that tvb_get_string_enc() is used.
    
    Don't bother checking whether NIBBLE_2_ASCHEX() returns an ASCII hex
    digit character or not - it returns either a value in the ASCII range of
    '0' through '9' or in the range 'A' through 'F', all of which are ASCII
    hex digits.
    
    Fix get_bit() to set *length to 0 if the string we're returning is
    empty.
    
    Change-Id: Id331cfd0ab34d45892f98d228dc793a1e93d84e5
    Reviewed-on: https://code.wireshark.org/review/14717
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c873c0b   Install GNU autotools even on Snow Leopard.
    adds  8ba351b   Clean up some stuff.


Summary of changes:
 epan/dissectors/packet-iso8583.c |   45 +++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 22 deletions(-)