Wireshark-commits: [Wireshark-commits] master-1.12 edf4950: GSM CBCH: fix an out of bounds access
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Mar 2016 07:02:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=edf4950894204abbb5c661703289e3b3c6cf181d
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

edf4950 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    GSM CBCH: fix an out of bounds access
    
    As explained by Guy, we should use new_slots[i] and not new_slots[k]
    
    Bug: 12278
    Change-Id: Ifae44f9d5948bed5c4ee0442510724016e307dee
    Reviewed-on: https://code.wireshark.org/review/14678
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 0fe522dfc689c3ebd119f2a6775d1f275c5f04d8)
    Reviewed-on: https://code.wireshark.org/review/14691
    

Actions performed:

    from  47a40a5   wslua: handle parameters with const keyword when generating taps
    adds  edf4950   GSM CBCH: fix an out of bounds access


Summary of changes:
 epan/dissectors/packet-gsm_cbch.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)