Wireshark-commits: [Wireshark-commits] master 8f3ad91: Fix some warnings/errors of type git/epan/di
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Mar 2016 12:46:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f3ad919054003ea96c670ab663268b75aba3755
Submitter: Jörg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8f3ad91 by Joerg Mayer (jmayer@xxxxxxxxx):

    Fix some warnings/errors of type
    git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used
          [-Werror,-Wused-but-marked-unused]
            proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown"));
                                   ^
    Added manual change id because file-jpeg.c forced the use of commit -n
    
    Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb
    
    Fix warnings/errors of type:
    git/epan/dissectors/packet-ax25-kiss.c:205:52: error: 'pseudo_header' was marked unused but was
          used [-Werror,-Wused-but-marked-unused]
                            return capture_ax25( pd, l_offset, len, cpinfo, pseudo_header );
    
    Fix checkhf warnings:
    Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_netswitch
    Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_subswitch
    Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_poll_reply_trailer
    Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_rdm_universe
    Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_tod_data_universe
    
    Change-Id: Id1fa12afb97a8e9cd4ed0ea25351c3b2639c930e
    Reviewed-on: https://code.wireshark.org/review/14667
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  c0e4877   Fix some warnings/errors of type git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used       [-Werror,-Wused-but-marked-unused]         proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown"));                                ^ Added manual change id because file-jpeg.c forced the use of commit -n
    adds  8f3ad91   Fix some warnings/errors of type git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used       [-Werror,-Wused-but-marked-unused]         proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown"));                                ^ Added manual change id because file-jpeg.c forced the use of commit -n


Summary of changes:
 epan/dissectors/packet-a21.c           |    4 +-
 epan/dissectors/packet-acn.c           |    2 +-
 epan/dissectors/packet-adwin-config.c  |    2 +-
 epan/dissectors/packet-afp.c           |    6 +-
 epan/dissectors/packet-afs.c           |    2 +-
 epan/dissectors/packet-aim-generic.c   |    2 +-
 epan/dissectors/packet-aim-icq.c       |    2 +-
 epan/dissectors/packet-aim-location.c  |    2 +-
 epan/dissectors/packet-aim-ssi.c       |    4 +-
 epan/dissectors/packet-aim-sst.c       |    4 +-
 epan/dissectors/packet-aim.c           |    8 +--
 epan/dissectors/packet-alcap.c         |   58 +++++++++---------
 epan/dissectors/packet-amqp.c          |   12 ++--
 epan/dissectors/packet-amr.c           |    4 +-
 epan/dissectors/packet-ansi_637.c      |   36 +++++------
 epan/dissectors/packet-ansi_a.c        |  102 ++++++++++++++++----------------
 epan/dissectors/packet-ap1394.c        |    2 +-
 epan/dissectors/packet-app-pkix-cert.c |    2 +-
 epan/dissectors/packet-arcnet.c        |    6 +-
 epan/dissectors/packet-artnet.c        |   38 +-----------
 epan/dissectors/packet-assa_r3.c       |   16 ++---
 epan/dissectors/packet-at.c            |    2 +-
 epan/dissectors/packet-atm.c           |    2 +-
 epan/dissectors/packet-ax25-kiss.c     |    2 +-
 epan/dissectors/packet-ax25.c          |    2 +-
 25 files changed, 143 insertions(+), 179 deletions(-)