Wireshark-commits: [Wireshark-commits] master-2.0 d3da30f: Detect spurious retransmissions when the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 Mar 2016 01:45:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3da30f96f90abf625b257f719f3e66b27961417
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

d3da30f by Michael Cistera (michael.cistera@xxxxxxxxxxxx):

    Detect spurious retransmissions when the full segment is retransmitted
    
    The TCP dissector failed to recognize spurious retransmissions when the last ack
    exactly equaled the retransmitted packet's sequence number plus the len. This is
    standard TCP behavior so this feature was broken in most cases.
    
    Bug: 12282
    Change-Id: I90196cc79e786f92fd0d7be32816aad1d69d5718
    Reviewed-on: https://code.wireshark.org/review/14592
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    (cherry picked from commit df8b5cbdc0d012c750a5ae08885a57e0de13ebc5)
    Reviewed-on: https://code.wireshark.org/review/14607
    

Actions performed:

    from  e5fffb2   rtp_player: fix build with gtk < 2.22.0
    adds  d3da30f   Detect spurious retransmissions when the full segment is retransmitted


Summary of changes:
 epan/dissectors/packet-tcp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)