Wireshark-commits: [Wireshark-commits] master 01faf39: Remove constant variable (CID-280372)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 Mar 2016 00:05:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01faf397940c3f3e59078d648440a06140abaa4f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

01faf39 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Remove constant variable (CID-280372)
    
    This copied and stripped code has this variable which does
    not change. Remove this constant variable and the conditional
    statements related.
    
    Change-Id: I0741ef0ef8b8d1cbd52fc521bc6a91ad06c8b597
    Reviewed-on: https://code.wireshark.org/review/14594
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  df8b5cb   Detect spurious retransmissions when the full segment is retransmitted
    adds  01faf39   Remove constant variable (CID-280372)


Summary of changes:
 epan/dissectors/packet-gsm_a_rr.c |   13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)