Wireshark-commits: [Wireshark-commits] master 040f5e5: Remove some dead code in copied code (CID-28
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Mar 2016 11:43:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=040f5e5c1be75c81efa539dc242d2600364c7432
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

040f5e5 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Remove some dead code in copied code (CID-280297)
    
    The copied function retained features from its parent,
    which cannot be reached. Might as well remove them and
    replace with proper assert.
    
    Change-Id: I63838d6011420d6c4473b127da52e7f304376172
    Reviewed-on: https://code.wireshark.org/review/14531
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  bbcb1aa   WSUG: Change word in chapter VLAN resolving
    adds  040f5e5   Remove some dead code in copied code (CID-280297)


Summary of changes:
 epan/dissectors/packet-gsm_a_rr.c |   29 +----------------------------
 1 file changed, 1 insertion(+), 28 deletions(-)