Wireshark-commits: [Wireshark-commits] master-1.12 4446971: PKTC must be stricter with its Kerberos
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Mar 2016 02:11:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44469711f8310a53f39f535b0ad54cbb3d1fec9e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

4446971 by Michael Mann (mmann78@xxxxxxxxxxxx):

    PKTC must be stricter with its Kerberos application choices.
    
    The PKTC dissector calls the Kerberos dissector assuming certain application values.  Because different application values can have different "private" data, corruption can occur.
    Ensure the Kerberos application values match the preceding comments by checking the ber identifier before calling the Kerberos dissector.
    
    # Conflicts:
    #	epan/dissectors/packet-kerberos.c
    #	epan/dissectors/packet-pktc.c
    
    (cherry picked from commit 4cdc9eeba58f866bd5f273e9c5b3876857a7a4bf)
    
    Bug: 12206
    Change-Id: I5ffd94d86f0a4689169c47b58662988c5b8e433d
    Reviewed-on: https://code.wireshark.org/review/14541
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3847c67   Fix response ok packet with no session tracking info but flag set
    adds  4446971   PKTC must be stricter with its Kerberos application choices.


Summary of changes:
 asn1/kerberos/kerberos.cnf        |    2 +
 epan/dissectors/packet-kerberos.c |   92 ++++++++++++++++++-------------------
 epan/dissectors/packet-kerberos.h |   20 ++++++++
 epan/dissectors/packet-pktc.c     |   43 +++++++++++++----
 4 files changed, 103 insertions(+), 54 deletions(-)