Wireshark-commits: [Wireshark-commits] master 4cdc9ee: PKTC must be stricter with its Kerberos appl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Mar 2016 14:04:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4cdc9eeba58f866bd5f273e9c5b3876857a7a4bf
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4cdc9ee by Michael Mann (mmann78@xxxxxxxxxxxx):

    PKTC must be stricter with its Kerberos application choices.
    
    The PKTC dissector calls the Kerberos dissector assuming certain application values.  Because different application values can have different "private" data, corruption can occur.
    Ensure the Kerberos application values match the preceding comments by checking the ber identifier before calling the Kerberos dissector.
    
    Bug: 12206
    Change-Id: I9b04837f93a56681cae3816278315cf01da17544
    Reviewed-on: https://code.wireshark.org/review/14520
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  92db934   Fix CMake target FOLDER properties
    adds  4cdc9ee   PKTC must be stricter with its Kerberos application choices.


Summary of changes:
 epan/dissectors/packet-pktc.c |   21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)