Wireshark-commits: [Wireshark-commits] master 54fc004: Qt: Make sure the proto tree handles all of
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 Mar 2016 05:02:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54fc0046cb87405f1b650c3c10ae6701d8d00505
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

54fc004 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Make sure the proto tree handles all of its timers.
    
    Call QTreeWidget::timerEvent from ProtoTree::timerEvent, otherwise we
    turn into the candy factory episode in I Love Lucy.
    
    Do the equivalent in WirelessFrame while we're here. Neither QFrame or
    QWidget use timers, but there's no guarantee that this will be the case
    in the future.
    
    Bug: 12258
    Change-Id: I3cb0096fe2ed87176fec8d7361260b5388d75530
    Reviewed-on: https://code.wireshark.org/review/14470
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jim Young <jim.young.ws@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4aafd44   Dump out abi_logs/log.txt if abi-compliance-checker fails.
    adds  54fc004   Qt: Make sure the proto tree handles all of its timers.


Summary of changes:
 ui/qt/proto_tree.cpp     |    2 ++
 ui/qt/wireless_frame.cpp |    5 ++++-
 ui/qt/wireless_frame.h   |    2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)