Wireshark-commits: [Wireshark-commits] master ec07578: Try to suppress a compiler feature that goes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Mar 2016 16:59:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec075789e31942008eb8ad7faf35b7012778dac8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ec07578 by Guy Harris (guy@xxxxxxxxxxxx):

    Try to suppress a compiler feature that goes wrong.
    
    -Warray-bounds + the macros for strcmp() = pain.  Either the macro is
    doing something wrong or the compiler is confused, because
    
    	if( strcmp(argv[i],"--")==0 ) dashdash = 1;
    
    should not produce
    
    	array index 3 is past the end of the array (which contains 3
    	elements)
    
    Either 1) the macro is blithely running past the end of "--", which
    does, indeed, contain only 3 elements, or 2) the compiler mistakenly
    believes that the code generated by the macro is running past the end of
    "--" when it isn't.
    
    Change-Id: I4183e29272ba9e05b3b370efd90102f2226df7c3
    Reviewed-on: https://code.wireshark.org/review/14469
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4aa0490   OS X: Remove GTK+ packaging.
    adds  ec07578   Try to suppress a compiler feature that goes wrong.


Summary of changes:
 configure.ac |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)