Wireshark-commits: [Wireshark-commits] master 3eafa0b: CIP: Improve info column information
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3eafa0b4a64689a0889f6edb3f7d8ef19750101b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
3eafa0b by D. Ulis (daulis0@xxxxxxxxx):
CIP: Improve info column information
1. Remove "Object" from CIP class names. It was already removed from some of the objects, the string "Object" is implied for all objects, and it helps reduce wordiness in the Info column.
2. Don't display Class/Symbol name in the Info column when it's inside a MSP.
3. Enable enhanced Info column by default now that some of the additional wordiness was removed by the above points.
4. Put single quotes around the symbol name in the Info column. This makes it more obvious that something is a symbol instead of an actual class name from the spec, and would prevent ambiguity if the symbol name was something like "Identity".
5. Print the CIP service for both requests/responses in CIP Safety processing. This was already added to normal CIP.
6. Display Class/Symbol and service on the Service Packet in the MSP tree. This makes it easier to find without expanding every MSP item.
Change-Id: I7197dd4bf3dad6d7bdba247d3d7ab76cca52c785
Reviewed-on: https://code.wireshark.org/review/14325
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: D. Ulis <daulis0@xxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from e0fe8c2 3GPP NAS: fix dissection of GMM Identity Request, Response and Authentication and Ciphering Failure messages
adds 3eafa0b CIP: Improve info column information
Summary of changes:
epan/dissectors/packet-cip.c | 248 +++++++++++++++++++-----------------
epan/dissectors/packet-cip.h | 4 +-
epan/dissectors/packet-cipsafety.c | 14 +-
3 files changed, 141 insertions(+), 125 deletions(-)
