Wireshark-commits: [Wireshark-commits] lts-1.12.1 3bd3e46: rsl: avoid buffer overread
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 4 Mar 2016 16:08:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3bd3e46535c73796a8f485ea0e171323d61484a4
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

3bd3e46 by Peter Wu (peter@xxxxxxxxxxxxx):

    rsl: avoid buffer overread
    
    Fixes a buffer overrun in dissct_rsl_ipaccess_msg when the tag is
    exactly 0xff:
    
            tag = tvb_get_guint8(tvb, offset);
            tdef = &rsl_att_tlvdef.def[tag];
    
    Bug: 11829
    Change-Id: I25a3c6948242a52f59431ce84c108b2e52008930
    Reviewed-on: https://code.wireshark.org/review/14011
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit de65fd6b00d0b891930324b9549c93ccfe9cac30)
    Reviewed-on: https://code.wireshark.org/review/14013
    (cherry picked from commit 08d1876a23668470ea4f706ee6d7a5f102d72810)
    Reviewed-on: https://code.wireshark.org/review/14342
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  d284d7e   Prevent infinite loop in DNP3 dissector.
    adds  3bd3e46   rsl: avoid buffer overread


Summary of changes:
 epan/dissectors/packet-rsl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)