Wireshark-commits: [Wireshark-commits] master dc92e98: Define in one and only one C file, declare i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Mar 2016 01:38:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc92e98db42c6ef55616940bc26cc989180fefdc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dc92e98 by Guy Harris (guy@xxxxxxxxxxxx):

    Define in one and only one C file, declare in a header file.
    
    Presumably the intent is to have the two dissectors share the tables in
    question; if so, it's best done by defining the tables in one and only
    one C file and declaring it in a header file included by both C files -
    that 1) ensures the declaration and definition stay in sync and 2) keeps
    the OS X build from failing.
    
    Change-Id: Id2e7e5b7270c7109ffb091b2e16a631b83dde212
    Reviewed-on: https://code.wireshark.org/review/14309
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ed6554c   Make the source and destination address code look more similar.
    adds  dc92e98   Define in one and only one C file, declare in a header file.


Summary of changes:
 epan/dissectors/packet-gtp.h   |    6 ++++++
 epan/dissectors/packet-gtpv2.c |    5 -----
 2 files changed, 6 insertions(+), 5 deletions(-)