Wireshark-commits: [Wireshark-commits] master 5b212e1: Dissect the FCS after dissecting the header.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Mar 2016 18:29:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b212e14372f7347325cb024e9cd884a9a4b5c59
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5b212e1 by Guy Harris (guy@xxxxxxxxxxxx):

    Dissect the FCS after dissecting the header.
    
    First dissect the address field, then dissect the control field, then
    dissect the FCS if present, then dissect the info field.
    
    That makes the dissection more like the dissection of other protocols
    with an FCS at the end, and means that we don't throw an exception too
    early.
    
    Remove the "MLT CHANGES" comments - if somebody cares who did what, they
    can browse the commit history; it's not as if the version prior to those
    changes was somehow the "pure" version and that we need to keep the
    changes carefully demarcated.
    
    Get rid of no-longer-necessary variable.
    
    Change-Id: I249440971e64ecbb0959ebbea1b2897a2e12375a
    Reviewed-on: https://code.wireshark.org/review/14293
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  429c840   Add Fop 2.1 to FindFOP.cmake.
    adds  5b212e1   Dissect the FCS after dissecting the header.


Summary of changes:
 epan/dissectors/packet-gprs-llc.c |  446 ++++++++++++++++++-------------------
 1 file changed, 220 insertions(+), 226 deletions(-)