Wireshark-commits: [Wireshark-commits] master c73cf3c: Don't show a progress bar when previewing fo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 1 Mar 2016 02:53:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c73cf3cd00c1fb144e67ef79ea55be41993b79be
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c73cf3c by Guy Harris (guy@xxxxxxxxxxxx):

    Don't show a progress bar when previewing for the Qt print dialog.
    
    We don't do much work to do that - we don't print anything before the
    first selected page, and once we're finished generating that page, we
    terminate the printing process - so it shouldn't need a progress bar.
    (If it needs a progress bar, We Have A Problem, as that slows down the
    drawing of the dialog box.)
    
    This should prevent the problem seen in bug 12040.
    
    Bug: 12040
    Change-Id: I129191e06fff3e1eb59a9631c7395b9e7f650809
    Reviewed-on: https://code.wireshark.org/review/14255
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c0b29fc   Add a #define for the wildcard pattern that matches all files.
    adds  c73cf3c   Don't show a progress bar when previewing for the Qt print dialog.


Summary of changes:
 file.c                             |   28 +++++++++++++++-------------
 file.h                             |    4 +++-
 ui/gtk/print_dlg.c                 |    2 +-
 ui/qt/export_dissection_dialog.cpp |    2 +-
 ui/qt/print_dialog.cpp             |   14 ++++++++------
 ui/win32/file_dlg_win32.c          |    4 ++--
 6 files changed, 30 insertions(+), 24 deletions(-)