Wireshark-commits: [Wireshark-commits] master 0e5a73f: Only say we have a new resolved MAC address
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Feb 2016 11:20:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e5a73fa4e8804c07cf56d6b0e47232ba536621c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0e5a73f by Guy Harris (guy@xxxxxxxxxxxx):

    Only say we have a new resolved MAC address if it's actually *new*.
    
    If we aren't changing the resolved name, it's not new.
    
    This prevents us from perpetually "resolving" the address.  If we have
    ARP packets that cause us to map a MAC address to a host name, based on
    the ARP packet saying the MAC address corresponds to a given resolved IP
    address, then each time we dissect the packet, the address will be
    "resolved" - and each time we have new resolved addresses as a result of
    that, we'll redissect the displayed packets so that they show the
    resolved address, and we'll forever be redissecting.
    
    Change-Id: I445e92f407d52a4ed5986721ffcc472f86e99431
    Reviewed-on: https://code.wireshark.org/review/14236
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d5f2db6   DISv7: parse PDU Status field
    adds  0e5a73f   Only say we have a new resolved MAC address if it's actually *new*.


Summary of changes:
 epan/addr_resolv.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)