Wireshark-commits: [Wireshark-commits] master 0165e67: u3v: use interface class and subclass in heu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Feb 2016 20:49:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0165e679d62162dcf3e7f334237f9416a21310a6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0165e67 by Martin Kaiser (wireshark@xxxxxxxxx):

    u3v: use interface class and subclass in heuristic checks
    
    don't access the class-specific conversation structure before we know
    that the packet is a U3V packet
    
    the USB dissector should fill interfaceClass and interfaceSubclass with
    correct values - if it doesn't that's another bug to be fixed
    
    Bug:12194
    Change-Id: Ic9e73e7cb05c8887fee794e4735936caad1b7f49
    Reviewed-on: https://code.wireshark.org/review/14224
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  df7c21b   TCP: Added bytes sent since last PSH flag
    adds  0165e67   u3v: use interface class and subclass in heuristic checks


Summary of changes:
 epan/dissectors/packet-u3v.c |   13 ++++---------
 epan/dissectors/packet-usb.c |    2 +-
 epan/dissectors/packet-usb.h |    2 ++
 3 files changed, 7 insertions(+), 10 deletions(-)