Wireshark-commits: [Wireshark-commits] master 3c6dab9: Qt: Improve Show Packet Bytes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Feb 2016 19:00:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c6dab95b4a6c14fec3e65fe4f5130a6e57ecf85
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3c6dab9 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Improve Show Packet Bytes
    
    - Add ShowAsASCIIandControl to keep ShowAsASCII only ASCII printable.
    - Enable show selected when ShowAsRAW.
    - Use QString::fromLatin1() when ShowAs8859_1.
    - Don't replace null with symbol for null when ShowAsUTF8.
    
    Change-Id: I25750247160e33d342fde12e6a998e3198270acf
    Reviewed-on: https://code.wireshark.org/review/14220
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  ddcafa0   wslua: don't crash if disable_lua = true in init.lua
    adds  3c6dab9   Qt: Improve Show Packet Bytes


Summary of changes:
 docbook/wsug_src/WSUG_chapter_advanced.asciidoc |   11 ++-
 ui/qt/show_packet_bytes_dialog.cpp              |   85 +++++++++++++++++------
 ui/qt/show_packet_bytes_dialog.h                |    4 +-
 wsutil/utf8_entities.h                          |    1 -
 4 files changed, 74 insertions(+), 27 deletions(-)