Wireshark-commits: [Wireshark-commits] master e4c059f: Add free_address_wmem(), fix warnings [-Wcas
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Feb 2016 23:09:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4c059f67f3b29bcc26b1faf111bf647ac630e04 Submitter: Jo?o Valverde (j@xxxxxx) Changed: branch: master Repository: wireshark Commits: e4c059f by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx): Add free_address_wmem(), fix warnings [-Wcast-qual] Try to improve address API and also fix some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Second try, now passing test suite. Change-Id: Idc101cd866b6d4f13500c9d59da5c7a38847fb7f Reviewed-on: https://code.wireshark.org/review/13946 Petri-Dish: João Valverde <j@xxxxxx> Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: João Valverde <j@xxxxxx> Actions performed: from 9253791 Fix indentation. adds e4c059f Add free_address_wmem(), fix warnings [-Wcast-qual] Summary of changes: asn1/nbap/nbap.cnf | 24 +++--- asn1/nbap/packet-nbap-template.c | 2 +- asn1/t38/packet-t38-template.c | 2 +- epan/address.h | 138 ++++++++++++++++++++++++-------- epan/conversation_table.c | 8 +- epan/dissectors/packet-dcerpc.c | 16 ++-- epan/dissectors/packet-dcom.c | 2 +- epan/dissectors/packet-dvbci.c | 4 +- epan/dissectors/packet-enip.c | 23 ++---- epan/dissectors/packet-forces.c | 19 +++-- epan/dissectors/packet-ftp.c | 2 +- epan/dissectors/packet-ieee802154.c | 12 +-- epan/dissectors/packet-isakmp.c | 4 +- epan/dissectors/packet-jxta.c | 20 ++--- epan/dissectors/packet-lbtrm.c | 2 +- epan/dissectors/packet-lbtru.c | 2 +- epan/dissectors/packet-lbttcp.c | 2 +- epan/dissectors/packet-maccontrol.c | 2 +- epan/dissectors/packet-mgcp.c | 2 +- epan/dissectors/packet-ms-mms.c | 2 +- epan/dissectors/packet-msrp.c | 2 +- epan/dissectors/packet-nbap.c | 26 +++--- epan/dissectors/packet-openflow_v4.c | 48 +++++------ epan/dissectors/packet-openflow_v5.c | 48 +++++------ epan/dissectors/packet-radius.c | 2 +- epan/dissectors/packet-rdt.c | 2 +- epan/dissectors/packet-rpc.c | 2 +- epan/dissectors/packet-rtcp.c | 2 +- epan/dissectors/packet-rtp.c | 4 +- epan/dissectors/packet-sdp.c | 18 +++-- epan/dissectors/packet-sflow.c | 25 +++--- epan/dissectors/packet-sprt.c | 2 +- epan/dissectors/packet-ssl-utils.c | 2 +- epan/dissectors/packet-t38.c | 2 +- epan/dissectors/packet-teamspeak2.c | 4 +- epan/dissectors/packet-uma.c | 6 +- epan/dissectors/packet-vuze-dht.c | 2 +- epan/packet.c | 60 +++++++------- epan/reassemble.c | 16 ++-- epan/wslua/wslua_address.c | 42 +++++----- epan/wslua/wslua_field.c | 20 ++--- epan/wslua/wslua_tvb.c | 27 ++----- plugins/irda/packet-irda.c | 35 +++----- plugins/unistim/packet-unistim.c | 4 +- plugins/wimax/mac_hd_generic_decoder.c | 12 +-- plugins/wimax/packet-wmx.c | 2 +- ui/cli/tap-comparestat.c | 6 +- ui/gtk/compare_stat.c | 6 +- ui/gtk/follow_stream.c | 2 +- ui/gtk/graph_analysis.c | 10 +-- ui/gtk/rtp_player.c | 4 +- ui/gtk/rtp_stream_dlg.c | 8 +- ui/gtk/wlan_stat_dlg.c | 6 +- ui/tap-sctp-analysis.c | 22 ++--- ui/tap-sequence-analysis.c | 9 +-- ui/voip_calls.c | 17 ++-- 56 files changed, 397 insertions(+), 396 deletions(-)
- Prev by Date: [Wireshark-commits] master-2.0 47a7665: Fix indentation.
- Next by Date: [Wireshark-commits] master fcf4ed3: packet-nsh.c - Look for correct ethernet dissector name.
- Previous by thread: [Wireshark-commits] master-2.0 47a7665: Fix indentation.
- Next by thread: [Wireshark-commits] master fcf4ed3: packet-nsh.c - Look for correct ethernet dissector name.
- Index(es):