Wireshark-commits: [Wireshark-commits] master-2.0 5124ebb: vwr: fix heap-based buffer overflow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Feb 2016 12:19:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5124ebb6503818720f9093f7496e875e5f16aa94
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5124ebb by Peter Wu (peter@xxxxxxxxxxxxx):

    vwr: fix heap-based buffer overflow
    
    Commit v1.99.10rc0-316-gf28e23f added some additional room for the 16
    byte PLCP header and 1 byte L1P. These are however not part of the
    remaining data, only the header.
    
    Bug: 11795
    Change-Id: Ia6935d27366a07f818f147c9094a801429b049e2
    Reviewed-on: https://code.wireshark.org/review/12240
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit e395633224fd448fd93af0450b812228192d3a1b)
    Reviewed-on: https://code.wireshark.org/review/14116
    

Actions performed:

    from  20304a4   packet-nfs: fix double-free
    adds  5124ebb   vwr: fix heap-based buffer overflow


Summary of changes:
 wiretap/vwr.c |   11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)