Wireshark-commits: [Wireshark-commits] master 7c15566: packet-nfs: do not call g_hash_table_remove
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Feb 2016 11:57:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c15566fa1a92c2970cfd00331efad9b08c50241
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7c15566 by Tigran Mkrtchyan (tigran.mkrtchyan@xxxxxxx):

    packet-nfs: do not call g_hash_table_remove before g_hash_table_insert
    
    The g_hash_table_insert will remove and deallocate existing entry, so we
    don't need to do it at all.
    
    Change-Id: I661cadd8beea9585885e48c03a8b52561d1df778
    Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@xxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/14113
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  f897899   packet-nfs: fix double-free
    adds  7c15566   packet-nfs: do not call g_hash_table_remove before g_hash_table_insert


Summary of changes:
 epan/dissectors/packet-nfs.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)