Wireshark-commits: [Wireshark-commits] master e395633: vwr: fix heap-based buffer overflow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Feb 2016 06:02:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e395633224fd448fd93af0450b812228192d3a1b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e395633 by Peter Wu (peter@xxxxxxxxxxxxx):

    vwr: fix heap-based buffer overflow
    
    Commit v1.99.10rc0-316-gf28e23f added some additional room for the 16
    byte PLCP header and 1 byte L1P. These are however not part of the
    remaining data, only the header.
    
    Bug: 11795
    Change-Id: Ia6935d27366a07f818f147c9094a801429b049e2
    Reviewed-on: https://code.wireshark.org/review/12240
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ec691a9   De-canonicalize paths for file and directory path preferences.
    adds  e395633   vwr: fix heap-based buffer overflow


Summary of changes:
 wiretap/vwr.c |   11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)