Wireshark-commits: [Wireshark-commits] master-2.0 6b739e5: Qt: Capture and display filter fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Feb 2016 16:44:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b739e52323822f57934d5fda373e500a97c0515
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6b739e5 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Capture and display filter fixups.
    
    In SyntaxLineEdit make sure we emit textEdited when we complete a
    previously used filter. In CaptureInterfacesDialog, connect
    captureFilterComboBox::activated to filterEdited. These enusre that we
    fill in the capture filter column in CaptureInterfacesDialog.
    
    Change-Id: Ibbf7ab223e37f8f73d8ec0289f8c32692a7e17d4
    Reviewed-on: https://code.wireshark.org/review/14081
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit fd75aa2f3d8a6571ee23005a1f657040f4127d3a)
    Reviewed-on: https://code.wireshark.org/review/14097
    

Actions performed:

    from  d52c1a9   caputils: fix crash when calling 'dumpcap -i' without having WinPcap installed
    adds  6b739e5   Qt: Capture and display filter fixups.


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |    2 ++
 ui/qt/syntax_line_edit.cpp          |    1 +
 2 files changed, 3 insertions(+)