Wireshark-commits: [Wireshark-commits] master-2.0 d52c1a9: caputils: fix crash when calling 'dumpca
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Feb 2016 19:49:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d52c1a9892e267aa61a89d06985601b38063a8c0
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

d52c1a9 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    caputils: fix crash when calling 'dumpcap -i' without having WinPcap installed
    
    Add a test on err_str buffer presence before trying to use it,
    like what is done in other code paths.
    
    Bug: 12143
    Change-Id: I30ae49a33224dc190c202637767df9d7de2c0f2b
    Reviewed-on: https://code.wireshark.org/review/14074
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 13332353607ac00158bc36ab08e7442c9722ef24)
    Reviewed-on: https://code.wireshark.org/review/14080
    

Actions performed:

    from  22a24bc   HTTP2: Reduce resource usage.
    adds  d52c1a9   caputils: fix crash when calling 'dumpcap -i' without having WinPcap installed


Summary of changes:
 caputils/capture-wpcap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)