Wireshark-commits: [Wireshark-commits] master 5f8c555: sigcomp: don't THROW() an exception from a d
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Feb 2016 22:44:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f8c555615b35508b0d8cbcec31d53f67331752a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5f8c555 by Martin Kaiser (wireshark@xxxxxxxxx):

    sigcomp: don't THROW() an exception from a dissector
    
    when there's a decompression failure, we already flag up an expert info and exit
    we can just delete the exception
    
    in dissect_udvm_reference_operand_memory(), we return 0 on error and
    let the caller do a check
    
    Change-Id: I2cd301896794260457f57209e5efc0939b27b339
    Reviewed-on: https://code.wireshark.org/review/14063
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  14881e7   tshark: load decode_as_entries file
    adds  5f8c555   sigcomp: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-sigcomp.c |   29 +++++++++++++++++++++++++++--
 1 file changed, 27 insertions(+), 2 deletions(-)