Wireshark-commits: [Wireshark-commits] master-2.0 ddeba68: [SPICE] Prevent really long loop in diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Feb 2016 14:56:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ddeba689e496510d4a36e2df0f5695fc4817092c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ddeba68 by Michael Mann (mmann78@xxxxxxxxxxxx):

    [SPICE] Prevent really long loop in dissect_spice_link_capabilities.
    
    Not all paths will access the tvb to have it throw a bounds error for large loop values.
    
    Bug: 12151
    Change-Id: I74a6d0d8ddece0f95027493a7d408cc54d94d25a
    Reviewed-on: https://code.wireshark.org/review/14051
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 48de5c5a1b6678451c9e936b957138bac0c82f89)
    Reviewed-on: https://code.wireshark.org/review/14053
    

Actions performed:

    from  6c91f52   ieee80211: handle reserved grouping value
    adds  ddeba68   [SPICE] Prevent really long loop in dissect_spice_link_capabilities.


Summary of changes:
 epan/dissectors/packet-spice.c |  110 ++++++++++++++++++----------------------
 1 file changed, 49 insertions(+), 61 deletions(-)