Wireshark-commits: [Wireshark-commits] master-2.0 cc34993: Prevent inproper use of negative value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Feb 2016 12:54:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc34993ee98d0716e5f05b561fe3647233650eb3
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

cc34993 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Prevent inproper use of negative value
    
    Coverity rightfully complains about inproper use of negative value.
    maxlength special value '-1' should be handled appropriately.
    
    Change-Id: Ie1818121e39fa668094d012980016444ca868e6e
    Reviewed-on: https://code.wireshark.org/review/13978
    Reviewed-by: João Valverde <j@xxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit eb75ec1824e374c3b021ccee9e768e63a56de05c)
    Reviewed-on: https://code.wireshark.org/review/14049
    

Actions performed:

    from  1339147   MIH: fix exists multiple times with NOT compatible types
    adds  cc34993   Prevent inproper use of negative value


Summary of changes:
 epan/tvbuff.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)