Wireshark-commits: [Wireshark-commits] master-2.0 a3b384f: Fix various off-by-one in buffer sizes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Feb 2016 15:18:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a3b384f3e7ba73a163498f32ea67f0f49736ea1a
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a3b384f by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix various off-by-one in buffer sizes
    
    Some only allow buffer overruns (read), others also buffer overflows
    (write).
    
    Found by looking for '\[ *N *\]' where N is 255, 0xff, 15 and 0xf (case
    insensitive).
    
    Change-Id: I250687e2fdeb8fbd5eaf0bbb8251c3dab9640760
    Reviewed-on: https://code.wireshark.org/review/14034
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 3b644a75c9530b8fc60e2fa964dfb2ae327e240d)
    Reviewed-on: https://code.wireshark.org/review/14037
    

Actions performed:

    from  271b10d   ber: fix buffer overrun when handling empty sets
    adds  a3b384f   Fix various off-by-one in buffer sizes


Summary of changes:
 epan/dissectors/packet-q2931.c |    2 +-
 epan/dissectors/packet-q931.c  |    2 +-
 epan/dissectors/packet-q933.c  |    2 +-
 ui/cli/tap-gsm_astat.c         |   20 ++++++++++----------
 wiretap/catapult_dct2000.c     |    2 +-
 5 files changed, 14 insertions(+), 14 deletions(-)