Wireshark-commits: [Wireshark-commits] master-2.0 2f57ff7: Qt: Fix Open protocol preferences button
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2016 18:33:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f57ff787ecf11f6e556638da3437dea5245ae00
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

2f57ff7 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix Open protocol preferences button.
    
    Do showProtocolPreferences before removing the variable which
    this depends on.  The button does not work without at module.
    
    Change-Id: I7d31aa5ab19340a4102523b13de961e799cae5e4
    Reviewed-on: https://code.wireshark.org/review/14015
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit 472687b5e1554fd0b7051eb2ee17ca03b9e6211c)
    Reviewed-on: https://code.wireshark.org/review/14016
    

Actions performed:

    from  0865707   rsl: avoid buffer overread
    adds  2f57ff7   Qt: Fix Open protocol preferences button.


Summary of changes:
 ui/qt/preference_editor_frame.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)