Wireshark-commits: [Wireshark-commits] master 5fec8fa: BER/PER: Add dissector assertions to squelch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2016 15:48:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5fec8fa74619a69e3faeca01fd483157d39f7b13
Submitter: Jo?o Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5fec8fa by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    BER/PER: Add dissector assertions to squelch scan-build bugs
    
    packet-per.c:959:6: warning: Access to field 'aligned' results in a dereference of a null pointer (loaded from variable 'actx')
    packet-ber.c:1606:29: warning: Access to field 'pinfo' results in a dereference of a null pointer (loaded from variable 'actx')
    packet-ber.c:1612:24: warning: Access to field 'created_item' results in a dereference of a null pointer (loaded from variable 'actx')
    packet-ber.c:3156:41: warning: Access to field 'pinfo' results in a dereference of a null pointer (loaded from variable 'actx')
    packet-ber.c:3182:24: warning: Access to field 'created_item' results in a dereference of a null pointer (loaded from variable 'actx')
    
    Change-Id: Ibae00dc29a869701fe903a5b0c9944279aaa3df7
    Reviewed-on: https://code.wireshark.org/review/13936
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  0200cff   DLM3: Add support for the Need Slots Recovery Command Status Flag
    adds  5fec8fa   BER/PER: Add dissector assertions to squelch scan-build bugs


Summary of changes:
 epan/dissectors/packet-ber.c |    2 ++
 epan/dissectors/packet-per.c |    2 ++
 2 files changed, 4 insertions(+)