Wireshark-commits: [Wireshark-commits] master 61f73a3: Qt: Update AccordionFrame widgets to use com
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2016 12:16:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61f73a3262fe724b7b31f14e842a80c5121301dd
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

61f73a3 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Update AccordionFrame widgets to use common layout
    
    - Use QPushButton for buttons and set the "Find" button as default
      in SearchFrame.
    - Use QPushButton for buttons, added a "Packet:" label, and set
      the "Go to packet" button as default in GoToFrame.
    - Set Qt::WA_MacSmallSize in OS X for FilterExpressionFrame and
      PreferenceEditorFrame.
    - Removed QFrame::StyledPanel and QFrame::Raised from ColumnEditorFrame.
    - Update ui files to reflect that AccordionFrame is used for
      AddressEditorFrame, FilterExpressionFrame and PreferenceEditorFrame.
    
    Change-Id: Icfbfff973535317997109a1020dfe24ba932e098
    Reviewed-on: https://code.wireshark.org/review/13995
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  4c1869f   Don't call the hci_usb dissector through a dissector table.
    adds  61f73a3   Qt: Update AccordionFrame widgets to use common layout


Summary of changes:
 ui/qt/address_editor_frame.cpp    |    1 -
 ui/qt/address_editor_frame.ui     |   10 ++++++++--
 ui/qt/column_editor_frame.ui      |   14 +++++++-------
 ui/qt/filter_expression_frame.cpp |    6 ++++++
 ui/qt/filter_expression_frame.ui  |   10 ++++++++--
 ui/qt/main_window.cpp             |    1 +
 ui/qt/main_window.ui              |   14 ++++++++++++--
 ui/qt/main_window_slots.cpp       |    2 +-
 ui/qt/preference_editor_frame.cpp |   10 ++++++++--
 ui/qt/preference_editor_frame.ui  |   12 +++++++++---
 ui/qt/search_frame.ui             |   10 +++++++---
 11 files changed, 67 insertions(+), 23 deletions(-)