Wireshark-commits: [Wireshark-commits] master f4580ac: ssl: fix decryption when session ticket is n
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2016 03:33:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4580ac9edc8b53514ad6dc18130e1cd55df509f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f4580ac by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: fix decryption when session ticket is not used
    
    Do not use the client-supplied session ticket for decryption when the
    session is not resumed as the cached key (associated with that ticket)
    is invalid for this new session. SSL Session IDs are unaffected by this
    issue as only the server-issued Session ID is considered.
    
    This fixes decryption of a SSL capture which uses the keylog file for
    decryption, but where the session tickets are invalid because the server
    was restarted.
    
    Additionally, the session and session tickets stores are split to avoid
    exporting session tickets via File -> Export SSL Session keys. Session
    tickets should only be used internally, the CLIENT_RANDOM identifier is
    shorter and is the preferred method to link secrets.
    
    Change-Id: If96d7a4e89389825478e67e9a65401ce0607aa66
    Reviewed-on: https://code.wireshark.org/review/13994
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  eb75ec1   Prevent inproper use of negative value
    adds  f4580ac   ssl: fix decryption when session ticket is not used


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   16 ++++++++++++----
 epan/dissectors/packet-ssl-utils.h |    6 +++---
 2 files changed, 15 insertions(+), 7 deletions(-)