Wireshark-commits: [Wireshark-commits] master 6671b0d: usb: cleanup idProduct dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Feb 2016 13:16:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6671b0dea8a4b724814b698f7418d4c5d07c461a
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6671b0d by Christian Lamparter (chunkeey@xxxxxxxxxxxxxx):

    usb: cleanup idProduct dissection
    
    The current code which dissects the idProduct (and to some extend the
    idVendor) item for USB devices is overly complicated. A better method
    to format the product string in the right way is using:
    proto_tree_add_uint_format_value.
    
    This gets rid of the additinal string and item manipulation altogether.
    
    Change-Id: Iadd69b7dc284e62039402de53418f41460d88a5d
    Reviewed-on: https://code.wireshark.org/review/13973
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  2d133d6   Qt: Validate FindLineEdit regexp
    adds  6671b0d   usb: cleanup idProduct dissection


Summary of changes:
 epan/dissectors/packet-usb.c |   25 +++++++------------------
 1 file changed, 7 insertions(+), 18 deletions(-)