Wireshark-commits: [Wireshark-commits] master 416ca6b: CIP/ENIP: Attribute updates
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Feb 2016 05:56:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=416ca6b9c9cd181e59fc9f51f9628a7d4871ba80
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

416ca6b by D. Ulis (daulis0@xxxxxxxxx):

    CIP/ENIP: Attribute updates
    
    1. More Identity attributes
    2. Port attributes
    3. Set Attribute List request highlighted too much attribute data
    4. TCP/IP object, Attr 5 needs padding
    5. Switch most attributes to use wrappers instead of dissect_epath() directly.
    6. Change new Volume 8 attributes to treat path size as words instead of bytes, when parsing size+EPATH formats.
    
    Change-Id: I1b8c476475c6fbb9c7cdb99ec4a6c28934631a19
    Reviewed-on: https://code.wireshark.org/review/13898
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  95dee44   const gpointer -> gconstpointer
    adds  416ca6b   CIP/ENIP: Attribute updates


Summary of changes:
 epan/dissectors/packet-cip.c  |  210 ++++++++++++++++++++++++++++++++++++++++-
 epan/dissectors/packet-cip.h  |    8 ++
 epan/dissectors/packet-enip.c |  131 ++++++-------------------
 3 files changed, 243 insertions(+), 106 deletions(-)