Wireshark-commits: [Wireshark-commits] master e6f59d0: prefs: set correct context for a preference
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Feb 2016 05:11:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e6f59d04aadd56d2b4361afddeb652f096d900df
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e6f59d0 by Peter Wu (peter@xxxxxxxxxxxxx):

    prefs: set correct context for a preference
    
    When a pref is renamed (e.g. from eth.qinq_ethertype to
    vlan.qinq_ethertype), the latter module must be marked as changed.
    Otherwise the pref has no effect as the vlan handoff routine is not
    called.
    
    For consistency, set the module for preferences migrated from smpp (the
    gsm-sms-ud dissector does not have a handoff routine for these prefs,
    so it has no functional effect for that dissector).
    
    Undoes I89f4a2d125e18d113edec4bf35599f128249e913, fixes
    I2a49dce93fdc7fab4ab3dc52dad90288c2d17434.
    
    Change-Id: I255b49db23c7958f9fb2214c54f3f35386fa5e9a
    Reviewed-on: https://code.wireshark.org/review/13851
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3e44854   Squelch array compared to NULL coverity events.
    adds  e6f59d0   prefs: set correct context for a preference


Summary of changes:
 epan/prefs.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)