Wireshark-commits: [Wireshark-commits] master-2.0 38a01c8: llrp: limit recursion depth
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 9 Feb 2016 05:24:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38a01c8b4ec890703a5798e2b31263b9db33b46b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

38a01c8 by Evan Huus (eapache@xxxxxxxxx):

    llrp: limit recursion depth
    
    LLRP defines fairly complex parameter nesting which we handle via recursion,
    however this means a large crafted packet could cause very deep stacks and
    potentially stack overflows. Limit our recursive depth to an arbitrary, which
    should be more than enough for any legitimate packet (I hope).
    
    Bug: 12048
    Change-Id: I9ac31bddfa4ffd1a79809387d10d2261749b95e7
    Reviewed-on: https://code.wireshark.org/review/13795
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c17d978   QCP: Fix retina label calculations.
    adds  38a01c8   llrp: limit recursion depth


Summary of changes:
 epan/dissectors/packet-llrp.c |   67 +++++++++++++++++++++--------------------
 1 file changed, 35 insertions(+), 32 deletions(-)