Wireshark-commits: [Wireshark-commits] master-2.0 8f676eb: Qt: Restore sequence diagram labels, oth
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Feb 2016 17:32:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f676eb999d69539054281724b572e244cbebd66
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

8f676eb by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Restore sequence diagram labels, other fixes.
    
    SequenceDiagram implements time, address, and comment labels using
    QCPAxis::setTickVector and QCPAxis::setTickVectorLabels. It also calls
    QCPAxis::setTicks(false) so that we don't draw tick marks. It appears
    that doing so also disables the labels themselves in our current version
    of QCP. Set the tick pen to Qt::NoPen instead.
    
    Only draw node lines where we have nodes.
    
    Add notes about a retina issue and the need for zooming.
    
    Bug: 11710
    Change-Id: I88c30a1ddcd29832f86b1ca8c018c7fa6b6d64a7
    Reviewed-on: https://code.wireshark.org/review/13781
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 477769b82370102228056364bef31f2ac74c38b3)
    Reviewed-on: https://code.wireshark.org/review/13828
    

Actions performed:

    from  f4384e6   Lua: Remove WSLUA_ERROR on dissecting error
    adds  8f676eb   Qt: Restore sequence diagram labels, other fixes.


Summary of changes:
 ui/qt/sequence_diagram.cpp |   10 ++++++++--
 ui/qt/sequence_dialog.cpp  |    2 ++
 2 files changed, 10 insertions(+), 2 deletions(-)