Wireshark-commits: [Wireshark-commits] master 13ec77a: Add free_address_wmem() and other extensions
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 7 Feb 2016 23:22:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13ec77a9fc3af3b0b502820d0b55796c89997896 Submitter: Jo?o Valverde (j@xxxxxx) Changed: branch: master Repository: wireshark Commits: 13ec77a by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx): Add free_address_wmem() and other extensions to address API Try to improve 'address' API (to be easier/safer) and also avoid some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Change-Id: I7456516b12c67620ceadac447907c12f5905bd49 Reviewed-on: https://code.wireshark.org/review/13463 Petri-Dish: João Valverde <j@xxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: João Valverde <j@xxxxxx> Actions performed: from d762a89 GTK: Check if lrint() is usable, fix warnings [-Wbad-function-cast] adds 13ec77a Add free_address_wmem() and other extensions to address API Summary of changes: asn1/mpeg-audio/packet-mpeg-audio-template.c | 4 +- asn1/nbap/nbap.cnf | 24 ++--- asn1/nbap/packet-nbap-template.c | 2 +- asn1/t38/packet-t38-template.c | 2 +- epan/address.h | 132 +++++++++++++++++++------- epan/conversation_table.c | 8 +- epan/dissectors/packet-dcerpc.c | 16 ++-- epan/dissectors/packet-dcom.c | 2 +- epan/dissectors/packet-dvbci.c | 4 +- epan/dissectors/packet-enip.c | 23 ++--- epan/dissectors/packet-forces.c | 19 ++-- epan/dissectors/packet-ftp.c | 2 +- epan/dissectors/packet-ieee802154.c | 12 +-- epan/dissectors/packet-isakmp.c | 4 +- epan/dissectors/packet-jxta.c | 20 ++-- epan/dissectors/packet-lbtrm.c | 2 +- epan/dissectors/packet-lbtru.c | 2 +- epan/dissectors/packet-lbttcp.c | 2 +- epan/dissectors/packet-maccontrol.c | 2 +- epan/dissectors/packet-mgcp.c | 2 +- epan/dissectors/packet-mpeg-audio.c | 4 +- epan/dissectors/packet-ms-mms.c | 2 +- epan/dissectors/packet-msrp.c | 2 +- epan/dissectors/packet-nbap.c | 26 ++--- epan/dissectors/packet-openflow_v4.c | 48 +++++----- epan/dissectors/packet-openflow_v5.c | 48 +++++----- epan/dissectors/packet-radius.c | 2 +- epan/dissectors/packet-rdt.c | 2 +- epan/dissectors/packet-rpc.c | 2 +- epan/dissectors/packet-rtcp.c | 2 +- epan/dissectors/packet-rtp.c | 4 +- epan/dissectors/packet-sdp.c | 18 ++-- epan/dissectors/packet-sflow.c | 25 +++-- epan/dissectors/packet-sprt.c | 2 +- epan/dissectors/packet-ssl-utils.c | 2 +- epan/dissectors/packet-t38.c | 2 +- epan/dissectors/packet-teamspeak2.c | 4 +- epan/dissectors/packet-uma.c | 6 +- epan/dissectors/packet-vuze-dht.c | 2 +- epan/packet.c | 60 ++++++------ epan/reassemble.c | 16 ++-- epan/wslua/wslua_address.c | 42 ++++---- epan/wslua/wslua_field.c | 20 +--- epan/wslua/wslua_tvb.c | 27 ++---- plugins/irda/packet-irda.c | 35 ++----- plugins/unistim/packet-unistim.c | 4 +- plugins/wimax/mac_hd_generic_decoder.c | 12 +-- plugins/wimax/packet-wmx.c | 2 +- ui/cli/tap-comparestat.c | 6 +- ui/gtk/compare_stat.c | 6 +- ui/gtk/follow_stream.c | 2 +- ui/gtk/graph_analysis.c | 10 +- ui/gtk/rtp_player.c | 4 +- ui/gtk/rtp_stream_dlg.c | 8 +- ui/gtk/wlan_stat_dlg.c | 6 +- ui/tap-sctp-analysis.c | 22 +---- ui/tap-sequence-analysis.c | 9 +- ui/voip_calls.c | 17 ++-- 58 files changed, 395 insertions(+), 400 deletions(-)
- Prev by Date: [Wireshark-commits] master d762a89: GTK: Check if lrint() is usable, fix warnings [-Wbad-function-cast]
- Next by Date: [Wireshark-commits] master 387c886: autotools: Move SBC dependency to libwscodecs
- Previous by thread: [Wireshark-commits] master d762a89: GTK: Check if lrint() is usable, fix warnings [-Wbad-function-cast]
- Next by thread: [Wireshark-commits] master 387c886: autotools: Move SBC dependency to libwscodecs
- Index(es):