Wireshark-commits: [Wireshark-commits] master 2ecb5a9: Check whether Ness is valid as well.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 7 Feb 2016 20:52:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ecb5a9d52b8a9c278328cc18ae3db3584514d19
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2ecb5a9 by Guy Harris (guy@xxxxxxxxxxxx):

    Check whether Ness is valid as well.
    
    It's also used as an array index, and it also is no guaranteed to be in
    the proper range in all capture files, so bounds-check it.
    
    Make the variable's type match that of the field in the radio metadata.
    (It's never negative, so it's unsigned.)
    
    This appears to be the last of the unchecked array references from bug
    12085.
    
    Bug: 12085
    Change-Id: I3e5b821a9b70dfd520d01036f6f7d02008aca200
    Reviewed-on: https://code.wireshark.org/review/13806
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8a7b5ef   MAX_MCS_INDEX is a valid array index.
    adds  2ecb5a9   Check whether Ness is valid as well.


Summary of changes:
 epan/dissectors/packet-ieee80211-radio.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)