Wireshark · Wireshark-commits: [Wireshark-commits] master f87c261: ndps: don't THROW() an exception from a dissector

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f87c2616c490ebfbfabe9ed628da662f1473d065
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f87c261 by Martin Kaiser (wireshark@xxxxxxxxx):

    ndps: don't THROW() an exception from a dissector
    
    if we just return the offset, there's no need to check for overflows
    the caller continues dissection from the returned offset
    if the offset is invalid, the core routines will throw an exception
    
    if we call proto_item_set_end() with the calculated offset,
    we can do the range check using tvb_ensure_bytes_exist()
    
    Change-Id: I0e2a7b2a866596eda0d7ed4a948fbea8ed084845
    Reviewed-on: https://code.wireshark.org/review/13792
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  bafdbb1   TCAP: fix indent and add modelines (use 2 spaces)
    adds  f87c261   ndps: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-ndps.c |   24 +++---------------------
 1 file changed, 3 insertions(+), 21 deletions(-)