Wireshark-commits: [Wireshark-commits] master caf594b: Bluetooth: HCI: Vendor: Add expert info if n
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 6 Feb 2016 11:10:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=caf594bb3c8729dfe45a406c755f3f914393b675
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

caf594b by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: HCI: Vendor: Add expert info if not all is dissected
    
    If vendor dissector does not decode all bytes - it seems to be
    unexpected parameter.
    
    Also move vendor dissection tree under root as it is done for HCI CMD.
    
    >>>     CID 1247678:  Error handling issues  (CHECKED_RETURN)
    >>>     No check of the return value of "dissector_try_uint_new(hci_vendor_table, hci_vendor_data->manufacturer, tvb, pinfo, tree, 1, bluetooth_data)".
    >>>     CID 1247679:  Error handling issues  (CHECKED_RETURN)
    >>>     No check of the return value of "dissector_try_uint_new(hci_vendor_table, hci_vendor_data->manufacturer, tvb, pinfo, main_tree, 1, bluetooth_data)".
    
    Change-Id: Icdb8c1f166d5bc33cfc79c62d384ae416dfbf0cf
    Reviewed-on: https://code.wireshark.org/review/13737
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  08cf506   Bluetooth/6lowpan: Add missing handle for L2CAP CID
    adds  caf594b   Bluetooth: HCI: Vendor: Add expert info if not all is dissected


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |   10 ++++++++--
 epan/dissectors/packet-bthci_evt.c |   34 +++++++++++++++++++++++++++-------
 2 files changed, 35 insertions(+), 9 deletions(-)