Wireshark-commits: [Wireshark-commits] master 485af0a: Check whether mcs_index is sane, not just wh
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 6 Feb 2016 08:43:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=485af0aa41c70e95c274adc858e847d87a52dbfd
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

485af0a by Guy Harris (guy@xxxxxxxxxxxx):

    Check whether mcs_index is sane, not just whether it's set.
    
    Don't just check whether we *have* the MCS index, check whether it's a
    valid MCS index, before we use it in calculations.  Otherwise, we'll
    make out-of-bounds array accesses.
    
    (May or may not fix bug 12085, so just Ping-Bug for now.  It's necessary
    in any case.)
    
    Change-Id: I7119366397b260089aea35ae9fcd5ad9ec6b06f2
    Ping-Bug: 12085
    Reviewed-on: https://code.wireshark.org/review/13790
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8678e5a   GlusterFS: Add support for the SEEK procedure
    adds  485af0a   Check whether mcs_index is sane, not just whether it's set.


Summary of changes:
 epan/dissectors/packet-ieee80211-radio.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)