Wireshark · Wireshark-commits: [Wireshark-commits] lts-1.12.1 51e6114: Add bounds checks and fix a length argument.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51e6114bc224953db555957a6c8c446eb3b1913d
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

51e6114 by Guy Harris (guy@xxxxxxxxxxxx):

    Add bounds checks and fix a length argument.
    
    Before reading the record header of a REC_FRAME{2,4,6} record, make sure
    the record length is >= the length of that header.
    
    Whe calling fix_pseudo_header(), pass the actual length of the packet
    data, not the remaining length of the record (which may include
    padding), so we don't read past the end of the packet data.
    
    Bug: 11827
    Change-Id: I1c63a4cb014c4616ffdd202660e68c576f266872
    Reviewed-on: https://code.wireshark.org/review/12756
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 53a3e53fce30523d11ab3df319fba7b75d63076f)
    Reviewed-on: https://code.wireshark.org/review/12758
    (cherry picked from commit 3a3ddbd43eaa5ac3b90d938a641f02cd2266bdf4)
    Reviewed-on: https://code.wireshark.org/review/13774
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  3325265   NBAP : Verify conversation proto data exists before trying to access it
    adds  51e6114   Add bounds checks and fix a length argument.


Summary of changes:
 wiretap/ngsniffer.c |   49 ++++++++++++++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 15 deletions(-)