Wireshark-commits: [Wireshark-commits] lts-1.12.1 476a5da: [airpdcap] check the length of the WPA b
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 20:41:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=476a5da22f0ccf31a3f832ac4154a4c390d553bb
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

476a5da by Martin Kaiser (wireshark@xxxxxxxxx):

    [airpdcap] check the length of the WPA broadcast key we calculated
    
    return an error if our key is shorter than the key type required for the
    encryption method we detected
    
    this check prevents an out-of-bounds memory access when the key is copied
    
    Bug: 11826
    Change-Id: Ic779b5d87aa97a3b2d2b2c92ce12d0fff4a85adc
    Reviewed-on: https://code.wireshark.org/review/12743
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/12771
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 8110a703cc1f17222b3010b3993bbf8be21436d4)
    Reviewed-on: https://code.wireshark.org/review/13762
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  1d9c54c   Add boundary check for 802.11 decryption
    adds  476a5da   [airpdcap] check the length of the WPA broadcast key we calculated


Summary of changes:
 epan/crypt/airpdcap.c |    4 ++++
 1 file changed, 4 insertions(+)