Wireshark-commits: [Wireshark-commits] lts-1.12.1 9039c2b: DNS: Ignore Client Subnet option's data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 20:38:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9039c2b53312ed3103a48bf685d50b0d54470e09
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

9039c2b by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    DNS: Ignore Client Subnet option's data length when > 16
    
    When DNS Client Subnet length is > 16, the limit coming from avoid stack smashing with tvb_memcpy
    
    Issue reported by Boaz
    
    Bug:10988
    Change-Id: I6103ba47fac9817410c7fc399c18e96c66ab8438
    Reviewed-on: https://code.wireshark.org/review/7308
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 30651ab18b42e666f57ea239e58f3ff3a5e9c4ad)
    Reviewed-on: https://code.wireshark.org/review/11824
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 960ac0b0b15261a5bcb7435b613febd123d4e0be)
    Reviewed-on: https://code.wireshark.org/review/13757
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  fce6e2d   RPC: fix crash when calling NLMv4 SRT statistics
    adds  9039c2b   DNS: Ignore Client Subnet option's data length when > 16


Summary of changes:
 epan/dissectors/packet-dns.c |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)