Wireshark-commits: [Wireshark-commits] master-2.0 14c7391: Qt: Add check for field extractors
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 07:37:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14c7391e1e25f91417b52aff1993b79605eed8d4
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

14c7391 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Add check for field extractors
    
    The proto tree is needed in several cases when using Lua field extractors,
    because they fetch values from the tree.  Without a valid field extractor
    a Lua plugin may misbehave and display wrong column info.
    
    This fixes column issues when:
    - Calling resetColumns() in Qt.  This involves adding a display filter,
      change time display format, change name resolution and other changes
      in UI which requires column updates.
    - Print summary lines.
    - Export as CSV and PSML.
    
    Change-Id: Ieed6f8578cdf2759f1f836cd8413a4529b7bbd80
    Reviewed-on: https://code.wireshark.org/review/13708
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/13722
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  9d4a676   Don’t adjust time column widths in cf_open
    adds  14c7391   Qt: Add check for field extractors


Summary of changes:
 debian/libwireshark6.symbols |    1 +
 epan/column-utils.c          |   14 ++++++++++++++
 epan/column-utils.h          |    5 +++++
 epan/dfilter/dfilter.c       |    6 ++++++
 epan/dfilter/dfilter.h       |    4 ++++
 epan/wslua/wslua.h           |    1 +
 epan/wslua/wslua_field.c     |    5 +++++
 file.c                       |   10 +++++-----
 ui/qt/packet_list_record.cpp |    5 +++--
 9 files changed, 44 insertions(+), 7 deletions(-)