Wireshark-commits: [Wireshark-commits] master 651d860: Don’t adjust time column widths in cf_open
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 05:37:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=651d860d9038a30de1453c5315eb09a95622c199
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

651d860 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Don’t adjust time column widths in cf_open
    
    The time column widths should not be adjusted in cf_open() because
    we don’t have any packets yet and Qt resizeColumnToContents() will
    not adjust any widths but emits a sectionResized() with invalid or
    default values (new_width seems to always be 32).  This will in some
    cases (when start capturing packets) give wrong width values which
    is later stored in the recent file, and the time columns may end up
    narrow the next time the recent file is read.
    
    This fix is related to the column with issues previously compensated
    for in PacketList::sectionResized() (g4980d505).
    
    Change-Id: Id3b49069fe5d2b55d608cc7a6d32fe7851369bf9
    Reviewed-on: https://code.wireshark.org/review/13712
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  cc679ca   Qt: Add check for field extractors
    adds  651d860   Don’t adjust time column widths in cf_open


Summary of changes:
 file.c |    3 ---
 1 file changed, 3 deletions(-)