Wireshark · Wireshark-commits: [Wireshark-commits] master f6ff90f: RTPS: Added custom type dissection support for RTPS batches

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6ff90fed6b18af3885d2cd66452004977cbcf24
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f6ff90f by Juanjo Martin (juanjo@xxxxxxx):

    RTPS: Added custom type dissection support for RTPS batches
    
    In RTPS, regular samples are serialized with the format
    <encapsulation, serialized data> and thus, the dissection of the
    encapsulation was suggested to be done in the custom dissector.
    
    However, batches are serializing the encapsulation only once as
    <encapsulation, sample 1, sample 2>. This makes us need to dissect
    the encapsulation in the RTPS dissector and providing as (void*) data
    to the custom dissector. This way we support the regular samples
    dissection as well as the batches dissection.
    
    I have defined rtps_dissector_data in packet-rtps.h and I suggest
    we include that header file when we want to write a custom dissector.
    
    Bug: 12029
    Change-Id: I74ed4c31484f9a99ad6c44c6c34cc52be2adb7c8
    Reviewed-on: https://code.wireshark.org/review/13413
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2a2cb9d   Couchbase: Dissect multi-path mutation responses
    adds  f6ff90f   RTPS: Added custom type dissection support for RTPS batches


Summary of changes:
 epan/dissectors/packet-rtps.c |   48 +++++++++++++++++++++++++++++------------
 epan/dissectors/packet-rtps.h |    6 ++++++
 2 files changed, 40 insertions(+), 14 deletions(-)