Wireshark-commits: [Wireshark-commits] master 4b663db: Use the "no FCS" version of the Ethernet dis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Jan 2016 02:42:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b663db5aad728a04651bd44ac236a777248aa5a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4b663db by Guy Harris (guy@xxxxxxxxxxxx):

    Use the "no FCS" version of the Ethernet dissector.
    
    RFC 7348 Figures 1 and 2, in the Payload section, says
    
    	"(Note that the original Ethernet Frame's FCS is not included)"
    
    meaning that the inner Ethernet frame does *not* include an FCS.
    
    Also, update the protocol references (the I-D is now RFC 7348) and add
    the I-D for the group policy stuff.
    
    Remove some extra blank lines while we're at it.
    
    Change-Id: Ib94a43b95b0761e97d1406a1cca3687ee640e12d
    Ping-Bug: 9933
    Reviewed-on: https://code.wireshark.org/review/13343
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  25699b6   Don't look at pinfo->pseudo_header.
    adds  4b663db   Use the "no FCS" version of the Ethernet dissector.


Summary of changes:
 epan/dissectors/packet-vxlan.c |   16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)